Messages in this thread | | | Date | Fri, 14 Oct 2011 00:49:15 -0400 (EDT) | Subject | Re: [PATCH v2 14/29] sparc/PCI: convert to pci_create_root_bus() for correct root bus resources | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Fri, 14 Oct 2011 00:46:54 -0400 (EDT)
> From: Bjorn Helgaas <bhelgaas@google.com> > Date: Thu, 13 Oct 2011 22:28:18 -0600 > >> Convert from pci_create_bus() to pci_create_root_bus(). This way the root >> bus resources are correct immediately. This patch doesn't fix anything >> because sparc fixed them before scanning the bus, but it makes it more >> consistent with other architectures. >> >> I didn't work out where pcibios_fixup_bus() is called. I don't see a >> use of pci_scan_bus(), pci_scan_bus_parented(), or pci_scan_child_bus(). >> >> CC: David S. Miller <davem@davemloft.net> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > The pcibios_fixup_bus() case here (sparc64) is an artifact from when > we actually probed the PCI config space for device probing on sparc64, > and pci_bus_probe() would invoke it. > > Unfortunately we can't delete this function now even though it's empty > with your changes, because drivers/pci/probe.o is unconditionally > linked into the kernel when CONFIG_PCI even when an architecture > (such as sparc64) doesn't use the majority of the code in it.
Sorry, forgot to give this an ACK :-)
Acked-by: David S. Miller <davem@davemloft.net>
| |