Messages in this thread | | | Date | Fri, 14 Oct 2011 10:40:59 -0600 | From | Greg KH <> | Subject | Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v5) |
| |
On Fri, Oct 14, 2011 at 09:21:48AM -0700, Jesse Barnes wrote: > On Thu, 6 Oct 2011 14:08:18 -0400 > Neil Horman <nhorman@tuxdriver.com> wrote: > > > This patch adds a per-pci-device subdirectory in sysfs called: > > /sys/bus/pci/devices/<device>/msi_irqs > > > > This sub-directory exports the set of msi vectors allocated by a given > > pci device, by creating a numbered sub-directory for each vector beneath > > msi_irqs. For each vector various attributes can be exported. Currently the > > only attribute is called mode, which tracks the operational mode of that vector > > (msi vs. msix) > > > > Ok this adds new ABI in the form of sysfs files so I want to make sure > it's ok. > > Matthew has dreams of a more sophisticated MSI-X management scheme, but > it sounds to me like that will mostly affect the driver interfaces and > shouldn't be incompatible with the sysfs scheme you propose here. > > If so, great, we can pull this in and maybe one day someone will > implement better MSI-X support. > > If not, I'd like to hear objections now; Neil has been responsive and > fixed several issues. I don't want to block his patch unless we have > something concrete that it conflicts with.
Again, no objection from me at all.
greg k-h
| |