Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH 2/9] ASoC: da7210: Add support for line input and mic | From | Ashish Chavan <> | Date | Thu, 13 Oct 2011 14:25:38 +0530 |
| |
On Wed, 2011-10-12 at 15:53 +0100, Mark Brown wrote: > On Wed, Oct 12, 2011 at 08:28:12PM +0530, Ashish Chavan wrote: > > > +static const char *da7210_mic_bias_voltage_txt[] = { > > + "1.5", "1.6", "2.2", "2.3" > > +}; > > + > > +static const struct soc_enum da7210_mic_bias = > > + SOC_ENUM_SINGLE(DA7210_MIC_L, 4, 4, da7210_mic_bias_voltage_txt); > > + > > This shouldn't be application controllable, it's a board property and if > it needs to be managed it's likely to be by in kernel things like > accessory detection. We do have some older drivers that do this but > they're not good. Use platform data. >
In that case I think, it's better to remove it from here.
| |