lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i7core_edac: fix erroneous size of static array
Em 13-10-2011 17:03, Niklas Söderlund escreveu:
> On 10/13/2011 08:56 PM, Borislav Petkov wrote:
>
>> On Thu, Oct 13, 2011 at 02:24:54PM -0400, Niklas Söderlund wrote:
>>> Signed-off-by: Niklas Söderlund <niso@kth.se>
>>> ---
>>> drivers/edac/i7core_edac.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>>> index 70ad892..e0f6096 100644
>>> --- a/drivers/edac/i7core_edac.c
>>> +++ b/drivers/edac/i7core_edac.c
>>> @@ -441,7 +441,7 @@ static inline int numrow(u32 row)
>>>
>>> static inline int numcol(u32 col)
>>> {
>>> - static int cols[8] = {
>>> + static int cols[4] = {
>>> 1 << 10, 1 << 11, 1 << 12, -EINVAL,
>>> };
>>
>> Even better,
>>
>> you could completely remove the number in the [] since the {}
>> initializer contains all array elements already. In this and the
>> remaining arrays in those small inline functions.
>>
>
>
> Thanks for the feedback!
>
> What would be the correct way of submitting an updated patch? Sending it
> in this mail thread or create a new one?

[PATCHv2] is the usual way. if you're using git, you may use the msgid of
the first message as a reference for the version 2.

Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-13 22:09    [W:0.322 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site