lkml.org 
[lkml]   [2011]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] mm/huge_memory: Clean up typo when updating mmu cache
From
Hi Andrea

There are three cases of update_mmu_cache() in the file, and the case in
function collapse_huge_page() has a typo, namely the last parameter used,
which is corrected based on the other two cases.

Due to the define of update_mmu_cache by X86, the only arch that implements
THP currently, the change here has no really crystal point, but one or two
minutes of efforts could be saved for those archs that are likely to support
THP in future.

Thanks

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/huge_memory.c Sat Aug 13 11:45:14 2011
+++ b/mm/huge_memory.c Thu Oct 13 20:07:29 2011
@@ -1906,7 +1906,7 @@ static void collapse_huge_page(struct mm
BUG_ON(!pmd_none(*pmd));
page_add_new_anon_rmap(new_page, vma, address);
set_pmd_at(mm, address, pmd, _pmd);
- update_mmu_cache(vma, address, entry);
+ update_mmu_cache(vma, address, _pmd);
prepare_pmd_huge_pte(pgtable, mm);
mm->nr_ptes--;
spin_unlock(&mm->page_table_lock);

\
 
 \ /
  Last update: 2011-10-13 14:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site