[lkml]   [2011]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/4] TTY: pty, release tty in all ptmx_open fail paths
    On Wednesday 12 October 2011, Jiri Slaby wrote:
    > Mistakenly, commit 64ba3dc3143d (tty: never hold BTM while getting
    > tty_mutex) switched one fail path in ptmx_open to not free the newly
    > allocated tty.
    > Fix that by jumping to the appropriate place. And rename the labels so
    > that it's clear what is going on there.
    > Introduced-in: v2.6.36-rc2
    > Signed-off-by: Jiri Slaby <>
    > Cc:
    > Cc: Arnd Bergmann <>
    > Cc: Alan Cox <>
    > Cc: Greg Kroah-Hartman <>

    Ok, I have checked that this patch returns the code into the state
    before my broken patch, that looks good.

    I think I made the same mistake trying to understand your patch
    that I made originally when I introduced the bug, which was to
    confuse the lifetime of the pty master with the lifetime of the
    slave device, so I thought that tty_release should not be called
    if we never called ptm_driver->ops->open(), but that's actually
    a different device.


     \ /
      Last update: 2011-10-12 15:25    [W:0.019 / U:195.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site