Messages in this thread | | | Date | Tue, 11 Oct 2011 22:12:16 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4 |
| |
On Tue, Oct 11, 2011 at 12:52:05PM -0600, Paul Walmsley wrote: > Hi Felipe > > On Tue, 11 Oct 2011, Felipe Balbi wrote: > > > maybe, but let's go with EXPORT_SYMBOL_GPL(). My only concern is that > > this IP comes from synopsys, and I'm not really keen on adding > > OMAP-specific, integration-related knowledge on a driver which was > > supposed to be reusable ;-) > > > > But at least for the time being, I guess that's what we need to do ;-) > > Which IP is coming from Synopsys - the TLL ? The EXPORT_SYMBOL approach
TLL and UHH are OMAP-only wrappers. EHCI and OHCI are Synopsys IPs for all I know.
> shouldn't add anything OMAP-specific to the TLL driver. So the exported > symbols should still be usable by drivers on other SoCs. But perhaps I am > misunderstanding your point?
A bit :-)
EHCI/OHCI will need to ask TLL to enable TLL clock, because it's EHCI/OHCI who configure the port. Unless I misunderstood what Keshava did (and no, I didn't just read the code, too lazy :-)
-- balbi [unhandled content-type:application/pgp-signature] | |