lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
On Tue, Oct 11, 2011 at 12:11:31PM +0200, Pelle Windestam wrote:
> On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@gmail.com> wrote:
> > Fixed the checkpatch warning about sing simple_strtoul instead of
> > kstrtoul() in panel.c.
> >
> > Signed-off-by: Pelle Windestam <iceaway@gmail.com>
> > ---
> >  drivers/staging/panel/panel.c |   10 ++++------
> >  1 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index b303b7e..4683d5f 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
> >                        break;
> >
> >                while (*esc) {
> > -                       char *endp;
> > -
> >                        if (*esc == 'x') {
> >                                esc++;
> > -                               lcd_addr_x = simple_strtoul(esc, &endp, 10);
> > -                               esc = endp;
> > +                               if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> > +                                       break;
> >                        } else if (*esc == 'y') {
> >                                esc++;
> > -                               lcd_addr_y = simple_strtoul(esc, &endp, 10);
> > -                               esc = endp;
> > +                               if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> > +                                       break;
> >                        } else
> >                                break;
> >                }
> > --
> > 1.7.3.4
> >
> >
>
> Was there any reason for not accepting this patch?

I don't recall ever seeing it before, care to resend it against the
latest linux-next tree so I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-11 18:23    [W:0.702 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site