lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/6] MFD: twl6040: Cache the vibra control registers
On Tue, Oct 11, 2011 at 03:48:24PM +0100, Mark Brown wrote:
> On Fri, Sep 23, 2011 at 09:49:40AM +0300, Peter Ujfalusi wrote:
> > The vibra control register will be used from the ASoC codec driver as well.
> > In order to avoid latency issues caused by I2C read access, cache the two
> > control register within the core driver, so we do not need to reach out
> > to the chip to read it back.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> It strikes me that it might be useful to just convert the driver to
> regmap and get cache for everything...
>
> Anyway, could you please restructure this series to minimize the
> dependency on the input subsystem? Then we can get the rest of it
> applied.
>

I'm OK with all patches going through MFD - I do not believe it will
cause any merge issues.

For the record I still do not like returning EBUSY when device is not
available - I think if device can't serve any requests it should not
exists at all.

--
Dmitry


\
 
 \ /
  Last update: 2011-10-11 18:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site