lkml.org 
[lkml]   [2011]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap3
    From
    On Tue, Oct 11, 2011 at 6:08 AM, Paul Walmsley <paul@pwsan.com> wrote:
    > Hi
    >
    > so I just noticed another problem with these hwmods:
    >
    > On Thu, 6 Oct 2011, Keshava Munegowda wrote:
    >
    >> Following 2 hwmod structures are added
    >>     1. usb_host_hs
    >>          The hwmod of usbhs with uhh, ehci and ohci base addresses
    >>          functional clock and ehci, ohci irqs
    >>
    >>     2. usb_tll_hs
    >>           hwmod of usbhs with the TLL base address and irq.
    >>
    >> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
    >> Reviewed-by: Partha Basak <parthab@india.ti.com>
    >> ---
    >>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  227 ++++++++++++++++++++++++++++
    >>  1 files changed, 227 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
    >> index 59fdb9f..b8ca690 100644
    >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
    >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
    >
    > ...
    >
    >> +static struct omap_hwmod_ocp_if omap34xx_ick_cfg__usb_tll_hs = {
    >
    > This interface is missing a .master and .slave.  It must have both.  So,
    > dropping this patch until it's fixed.
    >
    > Clearly we also need to modify the hwmod code needs to reject any
    > instances where either .master or .slave is NULL.
    >
    >
    > - Paul

    Hi Paul
    I will fix it today only and I will send the updated
    patches in couple of hours.
    please help me to make it in this merge window.

    Thanks and Regards
    keshava
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-11 07:51    [W:0.029 / U:0.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site