Messages in this thread | | | Date | Mon, 10 Oct 2011 18:40:11 -0600 (MDT) | From | Paul Walmsley <> | Subject | Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4 |
| |
Hi
and some comments on this one ...
On Thu, 6 Oct 2011, Keshava Munegowda wrote:
> From: Benoit Cousson <b-cousson@ti.com> > > Following 2 hwmod structures are added > 1. usb_host_hs > The hwmod of usbhs with uhh, ehci and ohci base addresses > functional clock and ehci, ohci irqs > > 2. usb_tll_hs > hwmod of usbhs with the TLL base address and irq. > > Signed-off-by: Benoit Cousson <b-cousson@ti.com> > > - rebased to kernel version 3.0 > - Workarounds for hardware issues > > Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com> > Reviewed-by: Partha Basak <parthab@india.ti.com> > --- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 206 +++++++++++++++++++++++++++- > 1 files changed, 205 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index 6201422..e404fd6 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
...
> +static struct omap_hwmod_ocp_if omap44xx_l4_cfg__usb_tll_hs = { > + .master = &omap44xx_l4_cfg_hwmod, > + .slave = &omap44xx_usb_tll_hs_hwmod, > + .addr = omap44xx_usb_tll_hs_addrs, > + .user = OCP_USER_MPU | OCP_USER_SDMA, > +};
This one has the .master pointing to something reasonable, but is missing a .clk entry.
- Paul
| |