lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/6] udf: Convert printks to pr_<level>
From
Date
On Mon, 2011-10-10 at 16:59 +0200, Jan Kara wrote:
> On Mon 10-10-11 01:08:05, Joe Perches wrote:
> > Use the current logging styles.
> >
> > Convert a few printks that should have been udf_warn and udf_err.
> > Coalesce formats. Add #define pr_fmt.
> > Move an #include "udfdecls.h" above other includes in udftime.c
> > so pr_fmt works correctly. Strip prefixes from conversions as appropriate.
> > Reorder logging definitions in udfdecl.h
> Any reason why you didn't use udf_err() / udf_warn() in all the places
> where sb pointer is available?

Oh, I forgot to mention that udf_err emits at KERN_CRIT.
I think that's not good.

It's either an error or it's a critical notification
and the pr_crit should be pr_err or the function should
be renamed.



\
 
 \ /
  Last update: 2011-10-10 17:25    [W:0.446 / U:0.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site