lkml.org 
[lkml]   [2011]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/6] udf: Convert printks to pr_<level>
    On Mon 10-10-11 01:08:05, Joe Perches wrote:
    > Use the current logging styles.
    >
    > Convert a few printks that should have been udf_warn and udf_err.
    > Coalesce formats. Add #define pr_fmt.
    > Move an #include "udfdecls.h" above other includes in udftime.c
    > so pr_fmt works correctly. Strip prefixes from conversions as appropriate.
    > Reorder logging definitions in udfdecl.h
    Any reason why you didn't use udf_err() / udf_warn() in all the places
    where sb pointer is available? Also I'd further use udf_err() in
    udf_parse_options() - passing sb there is simple and additional information
    in the message is useful. Thanks.

    Honza
    --
    Jan Kara <jack@suse.cz>
    SUSE Labs, CR


    \
     
     \ /
      Last update: 2011-10-10 17:03    [W:0.022 / U:31.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site