Messages in this thread | | | Date | Sat, 1 Oct 2011 17:36:27 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH RFC V2 2/5] stop_machine: make stop_machine safe and efficient to call early |
| |
Hello,
On Sat, Oct 01, 2011 at 02:55:34PM -0700, Jeremy Fitzhardinge wrote: > From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > Make stop_machine() safe to call early in boot, before SMP has been > set up, by simply calling the callback function directly if there's > only one CPU online.
Maybe "before stop_machine is initialized" is better wording now both here and in the comment?
> [ Fixes from AKPM: > - add comment > - local_irq_flags, not save_flags > - also call hard_irq_disable() for systems which need it > > Tejun suggested using an explicit flag rather than just looking at > the online cpu count. ] > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: H. Peter Anvin <hpa@linux.intel.com> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Steven Rostedt <rostedt@goodmis.org>
Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |