[lkml]   [2011]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO
    On Fri, Jan 7, 2011 at 12:23 AM, Wim Van Sebroeck <> wrote:
    > Hi Mike,
    >> Do you have any interest in picking these patches up?  I'd like to get
    >> this hardware functionality mainlined as it would allow us to get
    >> closer to testing upstream kernels on our hardware.
    > I allready cleaned both drivers up, but I had to send the feedback still.
    > Basically for both drivers, I did the following:
    > * Change reboot_notifier by a platform shutdown
    > * remove CONFIG_WATCHDOG_NOWAYOUT ifdef-ery (since that exists allready in watchdog.h)
    > * return -ENOTTY as default ioctl err-code
    > * make watchdog_info a static const struct
    > * some small cleanups
    > This gives below code. Could you please review it?

    Hi Wim,

    Thanks for the quick response :)

    Both drivers look great. I read over the changes, they look good. I
    also applied them to 2.6.37 and tested them on our machines without
    any problems.

    The cleanups above seem fine to me. What did you mean by "Change
    reboot_notifier by a platform shutdown" though? I see that you
    removed the reboot_notifier, which is fine for our purposes. Was this
    a suggestion to have this stuff get called from platform code if
    needed? Am I missing something?

    Mike Waychison
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-01-07 23:27    [W:0.025 / U:57.396 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site