lkml.org 
[lkml]   [2011]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213
Date
Hi Grant,

On Thursday, January 06, 2011 1:39 AM, Grant Likely wrote:
> As far as examples go, drivers/mfd/timberdale.c seems
> reasonable, if a bit larger than what you need.

Thank you for your suggestion.
However, though seeing this driver, I didn't understand your intention.
It seems platform_device/platform_driver are not used in this.
Which part of this driver do you want to show me as reference ?

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

> -----Original Message-----
> From: Grant Likely [mailto:glikely@secretlab.ca] On Behalf Of
> Grant Likely
> Sent: Thursday, January 06, 2011 1:39 AM
> To: Tomoya MORINAGA
> Cc: David Brownell; spi-devel-general@lists.sourceforge.net;
> linux-kernel@vger.kernel.org; qi.wang@intel.com;
> yong.y.wang@intel.com; joel.clark@intel.com;
> kok.howg.ewe@intel.com; Toshiharu Okada
> Subject: Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213
>
> On Wed, Jan 05, 2011 at 11:34:20AM +0900, Tomoya MORINAGA wrote:
> > Hi Grant,
> >
> > On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote:
> > >As previously discussed on this list, I would like to see
> support for
> > >multiple bus instances implemented differently. Rather
> than storing
> > >the spi_master instances in an array in the pci device
> private data,
> > >the pci device should register a separate platform_device for each
> > >spi bus instance, and each of those bus instances should
> get bound to
> > >a topcliff_spi_bus driver which doesn't need to have any special
> > >knowledge about how many spi_master instances actually exist.
> > >
> > >Basically, the way it is implemented in this patch isn't taking
> > >advantage of the infrastructure and instance management
> provided by
> > >the driver model.
> >
> > I see.
> > I will modify like your suggestion.
> > Could you show the reference SPI driver using multi-instance ?
>
> In an multi-instance scenario, the spi driver is just a
> plain-jane platform_driver. There isn't anything special
> about it. Instead, the pci_driver becomes responsible to
> register one or more platform devices for the child busses.
> Much like one of the multifunction devices in drivers/mfd.
>
> As far as examples go, drivers/mfd/timberdale.c seems
> reasonable, if a bit larger than what you need.
>
> g.
>
> >
> > Thanks,
> > ---
> > Tomoya MORINAGA
> > OKI SEMICONDUCTOR CO., LTD.
> >
>



\
 
 \ /
  Last update: 2011-01-07 07:43    [W:0.054 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site