lkml.org 
[lkml]   [2011]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 09/32] drm/radeon: use system_wq instead of dev_priv->wq
    From
    Date
    On Tue, 2011-01-04 at 19:21 -0500, Alex Deucher wrote:
    > On Mon, Jan 3, 2011 at 8:49 AM, Tejun Heo <tj@kernel.org> wrote:
    > > With cmwq, there's no reason for radeon to use a dedicated workqueue.
    > > Drop dev_priv->wq and use system_wq instead.
    > >
    > > Because radeon_driver_irq_uninstall_kms() may be called from
    > > unsleepable context, the work items can't be flushed from there.
    > > Instead, init and flush from radeon_irq_kms_init/fini().
    > >
    > > While at it, simplify canceling/flushing of rdev->pm.dynpm_idle_work.
    > > Always initialize and sync cancel instead of being unnecessarily smart
    > > about it.
    > >
    > > Signed-off-by: Tejun Heo <tj@kernel.org>
    > > Cc: David Airlie <airlied@linux.ie>
    > > Cc: dri-devel@lists.freedesktop.org
    > > ---
    > > Only compile tested. Please feel free to take it into the subsystem
    > > tree or simply ack - I'll route it through the wq tree.
    >
    > Patch looks good to me. I'm not sure what's the best way to send this
    > upstream. I'm working on some irq changes in the same area now, so
    > I'd prefer if we pushed it through Dave's tree, but I can handle it
    > either way.

    I'll pull it into my tree for merging to Linus.

    Dave.

    >
    > Acked-by: Alex Deucher <alexdeucher@gmail.com>
    >




    \
     
     \ /
      Last update: 2011-01-06 05:35    [W:0.020 / U:33.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site