lkml.org 
[lkml]   [2011]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [Stable-review] [06/49] drm/kms: remove spaces from connector names (v2)
On Wed, 2011-01-05 at 15:00 -0800, Greg KH wrote:
> 2.6.32-longterm review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Alex Deucher <alexdeucher@gmail.com>
>
> commit e76116ca9671e2e5239054a40303b94feab585ad upstream.
>
> Grub doesn't parse spaces in parameters correctly, so
> this makes it impossible to force video= parameters
> for kms on the grub kernel command line.
>
> v2: shorten the names to make them easier to type.
[...]
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -144,10 +144,10 @@ static struct drm_conn_prop_enum_list dr
> { DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
> { DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
> { DRM_MODE_CONNECTOR_Component, "Component", 0 },
> - { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
> - { DRM_MODE_CONNECTOR_DisplayPort, "DisplayPort", 0 },
> - { DRM_MODE_CONNECTOR_HDMIA, "HDMI Type A", 0 },
> - { DRM_MODE_CONNECTOR_HDMIB, "HDMI Type B", 0 },
> + { DRM_MODE_CONNECTOR_9PinDIN, "DIN", 0 },
> + { DRM_MODE_CONNECTOR_DisplayPort, "DP", 0 },
[...]

Why change 'DisplayPort', which doesn't have a space in it? This might
break a previously working kernel command line.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-01-06 00:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site