Messages in this thread | | | Date | Wed, 05 Jan 2011 10:52:05 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] jump label: introduce static_branch() |
| |
On 01/05/2011 09:46 AM, Steven Rostedt wrote: > On Wed, 2011-01-05 at 18:15 +0100, Frederic Weisbecker wrote: >> On Wed, Jan 05, 2011 at 10:43:12AM -0500, Jason Baron wrote: >>> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h >>> index 152f7de..0ad9c2e 100644 >>> --- a/include/linux/jump_label.h >>> +++ b/include/linux/jump_label.h >>> @@ -22,6 +22,11 @@ struct module; >>> >>> #ifdef HAVE_JUMP_LABEL >>> >>> +static __always_inline bool static_branch(struct jump_label_key *key) >>> +{ >>> + return __static_branch(key); >> >> Not very important, but __static_branch() would be more self-explained >> if it was called arch_static_branch(). > > I disagree, I think it is very important ;-) > > Yes, the kernel has been moving to adding "arch_" to functions that are > implemented dependently by different archs. Please change this to > "arch_static_branch()". >
Indeed. This hugely simplifies knowing where to look and whose responsibility it is.
-hpa
| |