lkml.org 
[lkml]   [2011]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure
Date
On Wednesday 05 January 2011 01:37:25 Andrew Morton wrote:
> On Fri, 10 Dec 2010 00:16:57 +0200
>
> Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> > On Friday 10 December 2010 00:04:52 Peter Huewe wrote:
> > > This patch fixes a build failure by converting leds-h1940.c to use
> > > gpiolib for latch access introduced by 14477095abc6
> > > (ARM: h1940: Use gpiolib for latch access)
> > >
> > > Unfortunately this driver was not converted back then.
> >
> > I sent similar patch (however, my patch does gpio_request/gpio_free)
> > ~month ago.
> >
> > Here's link:
> > http://www.spinics.net/lists/arm-kernel/msg103429.html
>
> So which patch to use?
>
> I queued Peter's patch because it's simpler. I queued it for
> 2.6.38-rc1, taged for backporting into 2.6.37.x, so we have a bit of
> time to think about it.

It's simplier, but it does not request gpio before use. It will work, but will
print nasty warning.

Regards,
Vasily


\
 
 \ /
  Last update: 2011-01-05 08:11    [W:0.035 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site