lkml.org 
[lkml]   [2011]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2 v2] xen: HVM X2APIC support
> > @@ -1384,6 +1365,17 @@ static bool __init xen_hvm_platform(void)
> > return true;
> > }
> >
> > +bool xen_hvm_need_lapic(void)
> > +{
> > + if (xen_pv_domain())
> > + return false;
> > + if (xen_hvm_domain() && xen_feature(XENFEAT_hvm_pirqs) &&
> > + xen_have_vector_callback)
> > + return false;
> > + return (xen_cpuid_base() != 0);
> > +}
> > +EXPORT_SYMBOL_GPL(xen_hvm_need_lapic);
> > +

Since xen_hvm_domain() is always true if xen_cpuid_base() != 0, isn't
this more obviously written as:
if (!xen_hvm_domain())
return false;
if (xen_feature(XENFEAT_hvm_pirqs) && xen_have_vector_callback)
return false;
return true;
?

Also, checking for the XenVMMXenVMM signature alone seems like a very
broad test for checking the availability of a specific feature, is there
nothing more specific which we could/should be testing?

Ian.

--
Ian Campbell
Current Noise: Taint - Mass Appeal Sadness

What's a cult? It just means not enough people to make a minority.
-- Robert Altman



\
 
 \ /
  Last update: 2011-01-05 16:13    [W:0.183 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site