Messages in this thread | | | Date | Wed, 5 Jan 2011 11:19:40 +1100 | From | Herbert Xu <> | Subject | Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register() |
| |
On Tue, Jan 04, 2011 at 06:14:16PM -0600, Larry Finger wrote: > > If I didn't get lost in expanding all those macros, I think the above can end up > with what is essentially a negative value for the index of buf. Shouldn't the > right-hand side of the statement be > > (u32 *)PTR_ALIGN(&buf[PADLOCK_ALIGNMENT], PADLOCK_ALIGNMENT); > > That resolves to an index for buf from 0 to (PADLOCK_ALIGNMENT - 1).
PTR_ALIGN (and ALIGN) rounds up, not down.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |