lkml.org 
[lkml]   [2011]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC patch 2/5] trace event skb fix unassigned field
    On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
    > Acked- by: Neil Horman <nhorman@tuxdriver.com>
    >
    >
    > Sent from my Verizon Wireless Phone
    >
    > ----- Reply message -----
    > From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
    > Date: Tue, Jan 4, 2011 6:16 pm
    > Subject: [RFC patch 2/5] trace event skb fix unassigned field
    > To: "LKML" <linux-kernel@vger.kernel.org>
    > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
    >
    >
    > The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
    > leaving its trace output as garbage. Assign the value to 0 when skb is NULL
    > instead.

    Hm, if the skb is already null, we probably shouldn't send any trace.

    What about using TP_CONDITION() ?

    >
    > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    > CC: Steven Rostedt <rostedt@goodmis.org>
    > CC: Frederic Weisbecker <fweisbec@gmail.com>
    > CC: Ingo Molnar <mingo@elte.hu>
    > CC: Neil Horman <nhorman@tuxdriver.com>
    > CC: Thomas Gleixner <tglx@linutronix.de>
    > ---
    > include/trace/events/skb.h | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > Index: linux-2.6-lttng/include/trace/events/skb.h
    > ===================================================================
    > --- linux-2.6-lttng.orig/include/trace/events/skb.h
    > +++ linux-2.6-lttng/include/trace/events/skb.h
    > @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
    >
    > TP_fast_assign(
    > __entry->skbaddr = skb;
    > - if (skb) {
    > - __entry->protocol = ntohs(skb->protocol);
    > - }
    > + __entry->protocol = skb ? ntohs(skb->protocol) : 0;
    > __entry->location = location;
    > ),
    >
    >
    >


    \
     
     \ /
      Last update: 2011-01-05 00:57    [W:0.024 / U:30.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site