lkml.org 
[lkml]   [2011]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:sched/core] sched, autogroup: Fix reference leak
    On 01/04, tip-bot for Mike Galbraith wrote:
    >
    > The cgroup exit mess also uncovered a struct autogroup reference leak.
    > copy_process() was simply freeing vs putting the signal_struct,
    > stranding a reference.
    >
    > Signed-off-by: Mike Galbraith <efault@gmx.de>
    > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    > Cc: Oleg Nesterov <oleg@redhat.com>
    > LKML-Reference: <1293784350.6839.2.camel@marge.simson.net>
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    > ---
    > kernel/fork.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/fork.c b/kernel/fork.c
    > index b6f2475..0672444 100644
    > --- a/kernel/fork.c
    > +++ b/kernel/fork.c
    > @@ -1317,7 +1317,7 @@ bad_fork_cleanup_mm:
    > }
    > bad_fork_cleanup_signal:
    > if (!(clone_flags & CLONE_THREAD))
    > - free_signal_struct(p->signal);
    > + put_signal_struct(p->signal);

    Well, free_signal_struct() was correct. Without CLONE_THREAD
    sig->sigcnt must be equal to 1.

    But yes, autogroup puts sched_autogroup_exit() into put_signal_struct(),
    so this patch looks fine.

    Although I must admit, to me it would be more clean to simply move
    sched_autogroup_exit() from put_signal_struct() into free_signal_struct()
    instead.

    Oleg.



    \
     
     \ /
      Last update: 2011-01-04 16:07    [W:0.021 / U:120.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site