lkml.org 
[lkml]   [2011]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch 2/3] memcg: prevent endless loop when charging huge pages to near-limit group
    From
    On Mon, Jan 31, 2011 at 11:03 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:
    > If reclaim after a failed charging was unsuccessful, the limits are
    > checked again, just in case they settled by means of other tasks.
    >
    > This is all fine as long as every charge is of size PAGE_SIZE, because
    > in that case, being below the limit means having at least PAGE_SIZE
    > bytes available.
    >
    > But with transparent huge pages, we may end up in an endless loop
    > where charging and reclaim fail, but we keep going because the limits
    > are not yet exceeded, although not allowing for a huge page.
    >
    > Fix this up by explicitely checking for enough room, not just whether
    > we are within limits.
    >
    > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
    Reviewed-by: Minchan Kim <minchan.kim@gmail.com>


    --
    Kind regards,
    Minchan Kim


    \
     
     \ /
      Last update: 2011-01-31 23:45    [W:0.020 / U:63.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site