Messages in this thread | | | Date | Tue, 1 Feb 2011 07:42:48 +0900 | Subject | Re: [patch 2/3] memcg: prevent endless loop when charging huge pages to near-limit group | From | Minchan Kim <> |
| |
On Mon, Jan 31, 2011 at 11:03 PM, Johannes Weiner <hannes@cmpxchg.org> wrote: > If reclaim after a failed charging was unsuccessful, the limits are > checked again, just in case they settled by means of other tasks. > > This is all fine as long as every charge is of size PAGE_SIZE, because > in that case, being below the limit means having at least PAGE_SIZE > bytes available. > > But with transparent huge pages, we may end up in an endless loop > where charging and reclaim fail, but we keep going because the limits > are not yet exceeded, although not allowing for a huge page. > > Fix this up by explicitely checking for enough room, not just whether > we are within limits. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
-- Kind regards, Minchan Kim
| |