Messages in this thread | | | Date | Mon, 31 Jan 2011 07:53:39 +0100 | Subject | Re: [leds-pca9532] Add gpio capability v2 | From | Joachim Eastwood <> |
| |
On Sun, Jan 30, 2011 at 11:14 PM, Wolfram Sang <w.sang@pengutronix.de> wrote: > On Sun, Jan 30, 2011 at 09:20:13PM +0100, Joachim Eastwood wrote: >> Hello, >> >> This is v2 of the patch to add gpio capability to the leds-pca9532 >> driver. Please read the first mail in this thread for more >> information. >> >> Changes in v2: >> * Add Kconfig magic. gpio capability is now optional >> * Addressed review from Wolfram Sang >> >> Wolfram: If this looks okey can I add your Reviewed-by tag? > > The patch seems line-wrapped. Is checkpatch happy (enough), too? > Other than that looks good to me:
checkpatch reports a couple of line over 80 chars but that is it.
> Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks for your time.
regards Joachim Eastwood
> -- > Pengutronix e.K. | Wolfram Sang | > Industrial Linux Solutions | http://www.pengutronix.de/ | > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAk1F4soACgkQD27XaX1/VRvrLQCgpgfO88OCvM05+QIxaSV2LDRi > L/YAoKODhHKkogJdq3W1s1x0IuhvfceD > =+iVA > -----END PGP SIGNATURE----- > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |