lkml.org 
[lkml]   [2011]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2 v2.0]sched: Removing unused fields from /proc/schedstat
    Hi Satoru,

    >
    > This patch is logically correct, succeeded to compile and works
    > fine. But I came to be worried about whether it is good to kill
    > all fields you said after reading old and upstream scheduler
    > code again.
    >
    > I think we can remove rq->sched_switch and rq->sched_switch
    > without no problem because they are meaningless. The former
    > is for old O(1) scheduler and means the number of runqueue
    > switching among active/expired queue. The latter is for
    > SD_WAKE_BALANCE flag and its logic is already gone.
    >
    > However sbe_* are for SD_BALANCE_EXEC flag and sbf_* are for
    > SD_BALANCE_FORK flag. Since both logic for them are still alive,
    > the absence of these accounting is regression in my perspective.
    > In addition, these fields would be useful for analyzing load
    > balance behavior.
    >

    sbe_* & sbf_* flags are added by the commit
    68767a0ae428801649d510d9a65bb71feed44dd1 Git describe shows that it was
    gone in to v2.6.12-1422-g68767a0 which is quite old. So in my opinion
    this might not be a regression.

    > # although I haven't been able to notice they are always zero ;-(
    >
    > I prefer not to remove these fields({sbe,sbf}_*) but to add
    > accounting code for these flags again. What do you think?

    I will go through the code and verify once again.

    -Ciju



    \
     
     \ /
      Last update: 2011-01-31 05:13    [W:0.021 / U:2.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site