Messages in this thread | | | Date | Mon, 03 Jan 2011 11:37:26 -0800 (PST) | Subject | Re: [PATCH] net: eepro testing positive EBUSY return by request_irq()? | From | David Miller <> |
| |
From: roel kluin <roel.kluin@gmail.com> Date: Sun, 02 Jan 2011 15:52:23 +0100
> + for (i = 0; i < ARRAY_SIZE(irqlist); i++) { > + retval = request_irq (irqlist[i], NULL, 0, "bogus", NULL); > + if (retval != -EBUSY) > + continue; > + if (retval < 0) > + goto out; > + dev->irq = irqlist[i]; > + break;
This series of tests don't make much sense.
If we get to the "retval < 0" check, retval must be -EBUSY. So at best it's superfluous, at worst it's confusing.
| |