Messages in this thread | | | Date | Sun, 30 Jan 2011 00:26:14 +0800 | Subject | Re: [PATCH] gpio: Make gpio_{request,free}_array gpio array parameter const | From | Eric Miao <> |
| |
On Saturday, January 29, 2011, Lars-Peter Clausen <lars@metafoo.de> wrote: > gpio_{request,free}_array should not (and do not) modify the passed gpio array, > so make the parameter const. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
> --- > drivers/gpio/gpiolib.c | 4 ++-- > include/asm-generic/gpio.h | 4 ++-- > include/linux/gpio.h | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 649550e..27016c4 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1293,7 +1293,7 @@ EXPORT_SYMBOL_GPL(gpio_request_one); > * @array: array of the 'struct gpio' > * @num: how many GPIOs in the array > */ > -int gpio_request_array(struct gpio *array, size_t num) > +int gpio_request_array(const struct gpio *array, size_t num) > { > int i, err; > > @@ -1316,7 +1316,7 @@ EXPORT_SYMBOL_GPL(gpio_request_array); > * @array: array of the 'struct gpio' > * @num: how many GPIOs in the array > */ > -void gpio_free_array(struct gpio *array, size_t num) > +void gpio_free_array(const struct gpio *array, size_t num) > { > while (num--) > gpio_free((array++)->gpio); > diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h > index ff5c660..05119e7 100644 > --- a/include/asm-generic/gpio.h > +++ b/include/asm-generic/gpio.h > @@ -193,8 +193,8 @@ struct gpio { > }; > > extern int gpio_request_one(unsigned gpio, unsigned long flags, const char *label); > -extern int gpio_request_array(struct gpio *array, size_t num); > -extern void gpio_free_array(struct gpio *array, size_t num); > +extern int gpio_request_array(const struct gpio *array, size_t num); > +extern void gpio_free_array(const struct gpio *array, size_t num); > > #ifdef CONFIG_GPIO_SYSFS > > diff --git a/include/linux/gpio.h b/include/linux/gpio.h > index 32720ba..b2b610f 100644 > --- a/include/linux/gpio.h > +++ b/include/linux/gpio.h > @@ -41,7 +41,7 @@ static inline int gpio_request_one(unsigned gpio, > return -ENOSYS; > } > > -static inline int gpio_request_array(struct gpio *array, size_t num) > +static inline int gpio_request_array(const struct gpio *array, size_t num) > { > return -ENOSYS; > } > @@ -54,7 +54,7 @@ static inline void gpio_free(unsigned gpio) > WARN_ON(1); > } > > -static inline void gpio_free_array(struct gpio *array, size_t num) > +static inline void gpio_free_array(const struct gpio *array, size_t num) > { > might_sleep(); > > -- > 1.7.2.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |