lkml.org 
[lkml]   [2011]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSat, 29 Jan 2011 18:46:33 +0800
FromWu Fengguang <>
SubjectRe: [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm_bits()
On Sat, Jan 29, 2011 at 01:40:04AM +0100, Jesper Juhl wrote:

> if (a->format == AUDIO_CODING_TYPE_LPCM)
> - snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
> + snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);

Good catch!

Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>


\
 
 \ /
  Last update: 2011-01-29 11:49    [from the cache]
©2003-2010