lkml.org 
[lkml]   [2011]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] radeon: Fix wrong boolean operator
    Date
    This error is reported by cppcheck:
    drivers/gpu/drm/radeon/radeon_encoders.c:1066: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?

    It looks like cppcheck is correct, so fix this. No test was run.

    Cc: David Airlie <airlied@linux.ie>
    Cc: Alex Deucher <alexdeucher@gmail.com>
    Cc: dri-devel@lists.freedesktop.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Stefan Weil <weil@mail.berlios.de>
    ---
    drivers/gpu/drm/radeon/radeon_encoders.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
    index 5e90984..d4a5422 100644
    --- a/drivers/gpu/drm/radeon/radeon_encoders.c
    +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
    @@ -1063,7 +1063,7 @@ atombios_set_edp_panel_power(struct drm_connector *connector, int action)
    if (!ASIC_IS_DCE4(rdev))
    return;

    - if ((action != ATOM_TRANSMITTER_ACTION_POWER_ON) ||
    + if ((action != ATOM_TRANSMITTER_ACTION_POWER_ON) &&
    (action != ATOM_TRANSMITTER_ACTION_POWER_OFF))
    return;

    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-01-28 23:37    [W:0.019 / U:120.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site