Messages in this thread | | | Date | Fri, 28 Jan 2011 11:29:04 +0530 | From | Amit Shah <> | Subject | Re: [PATCH 1/3] tty: move hvc drivers to drivers/tty/hvc/ |
| |
On (Thu) Jan 27 2011 [20:21:25], Greg KH wrote: > > > Sorry about this, the idea to move this file was mine and my original > > > patch did this as well. I remembered the code from when it was a simple > > > console driver based on hvc and never noticed that it had evolved into > > > a generic host/guest communication stack. > > > > > > > Can you please move it back? > > > > > > No objection from me here in general, though as Greg writes above, it's > > > a bit ugly when hvc_console.h is in a different directory. > > > > Greg, can you do this please? (A way to do it with preservig git > > history of the file would be great as well, but I think only a revert > > will do that?) > > So just move the one file, virtio_console.c? If so, yes, I can move it > back.
Yes, just the one file.
> > > > I could perhaps think of a way of splitting the file so the hvc bits can > > > > be moved to drivers/tty/hvc/ and having the core stay in drivers/char/, > > > > but that'll have to wait for the next cycle. > > That would be great, care to send me those patches now so I can queue it > up for .39?
It was just a thought; I don't have patches yet. I'll send them your way once they're ready.
Thanks, Amit
| |