lkml.org 
[lkml]   [2011]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
On Thu, 27 Jan 2011 17:35:53 -0800 Joel Becker <jlbec@evilplan.org> wrote:

> > --- a/fs/ocfs2/dlm/dlmdomain.c~a
> > +++ a/fs/ocfs2/dlm/dlmdomain.c
> > @@ -926,9 +926,9 @@ static int dlm_assert_joined_handler(str
> > }
> >
> > static int dlm_match_regions(struct dlm_ctxt *dlm,
> > - struct dlm_query_region *qr)
> > + struct dlm_query_region *qr, u8 *local)
> > {
> > - char *local = NULL, *remote = qr->qr_regions;
> > + char *remote = qr->qr_regions;
>
> Won't the stack-depth busybodies hate us for this? I realize we
> don't go much deeper from here, but it still is 1K of stack.

+ static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */
^^^^^^


\
 
 \ /
  Last update: 2011-01-28 02:51    [W:0.073 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site