Messages in this thread | | | Date | Thu, 27 Jan 2011 17:48:57 -0800 | From | Andrew Morton <> | Subject | Re: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock |
| |
On Thu, 27 Jan 2011 17:35:53 -0800 Joel Becker <jlbec@evilplan.org> wrote:
> > --- a/fs/ocfs2/dlm/dlmdomain.c~a > > +++ a/fs/ocfs2/dlm/dlmdomain.c > > @@ -926,9 +926,9 @@ static int dlm_assert_joined_handler(str > > } > > > > static int dlm_match_regions(struct dlm_ctxt *dlm, > > - struct dlm_query_region *qr) > > + struct dlm_query_region *qr, u8 *local) > > { > > - char *local = NULL, *remote = qr->qr_regions; > > + char *remote = qr->qr_regions; > > Won't the stack-depth busybodies hate us for this? I realize we > don't go much deeper from here, but it still is 1K of stack.
+ static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */ ^^^^^^
| |