Messages in this thread |  | | | From | David Howells <> | | Subject | Re: rwsem: rwsem: Remove redundant asmregparm annotation | | Date | Thu, 27 Jan 2011 15:03:40 +0000 |
| |
Thomas Gleixner <tglx@linutronix.de> wrote:
> Peter Zijlstra pointed out, that the only user of asmregparm (x86) is > compiling the kernel already with -mregparm=3. So the annotation of > the rwsem functions is redundant. Remove it.
That's fine - as long as we never remove the -mregparm=3 on i386. The inline assembly relies on the regparm=3 calling convention.
David
|  |