lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] block: Create sysfs knobs to override FLUSH/FUA support flags
    On Tue, Jan 25, 2011 at 11:16:26PM -0800, Darrick J. Wong wrote:
    > This patch is the first in a series to refactor the barrier= mount options out
    > of the filesystem code. This patch adds sysfs knobs to disable flush and FUA;
    > of course, the automatic default is the safe choice, i.e. to leave them
    > enabled. Obviously, only a seasoned administrator should ever be overriding
    > the defaults.

    Hmmm... wouldn't it be better to just export flush and fua instead of
    ignore_*? So that the admin can turn things on and off as [s]he seems
    fit? Also, it might be better to export them in a single attribute,
    say cache_control or something. Only subset of the combinations make
    sense anyway - none, flush, flush_fua.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-01-26 10:33    [W:0.020 / U:30.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site