lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] use %pK for /proc/kallsyms and /proc/modules
Hi,

On Wed, Jan 26, 2011 at 03:57:06PM -0800, Andrew Morton wrote:
> On Tue, 25 Jan 2011 10:10:58 -0800
> Kees Cook <kees.cook@canonical.com> wrote:
>
> > Instead of messing with permissions on these files,
>
> This implies that the patch alters permission handling, only it
> doesn't. But I worked it out!

Ah yeah, this was related to the earlier attempts to remove the contents
of, or set permissions on, /proc/kallsyms.

> > Note that this changes %x to %p, so some legitimately 0 values in
> > /proc/kallsyms would have changed from 00000000 to "(null)". To avoid
> > this, "(null)" is not used when using the "K" format. Anything parsing
> > such addresses should have no problem with this change. (Thanks to Joe
> > Perches for the suggestion.)
>
> OK, so what applications did this patch just break?

I'm not aware of any breakage as a result of this yet.

-Kees

--
Kees Cook
Ubuntu Security Team


\
 
 \ /
  Last update: 2011-01-27 01:33    [W:0.264 / U:0.316 seconds]
©2003-2014 Jasper Spaans. Advertise on this site