lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 26/25] mm, arch: Convert ia64, arm, sh to generic tlb
> Index: linux-2.6/include/asm-generic/tlb.h
> ===================================================================
> --- linux-2.6.orig/include/asm-generic/tlb.h
> +++ linux-2.6/include/asm-generic/tlb.h
> @@ -79,6 +79,10 @@ struct mmu_gather {
> fast_mode : 1; /* No batching */
> unsigned int fullmm; /* Flush full mm */
>
> +#ifdef CONFIG_HAVE_MMU_GATHER_RANGE
> + unsigned long start, end;
> +#endif
> +
> struct mmu_gather_batch *active;
> struct mmu_gather_batch local;
> struct page *__pages[8];

Not related to this patch per see.

But if you anyway touch this header could you then fix
following comment:

/* Users of the generic TLB shootdown code must declare this storage space. */
DECLARE_PER_CPU(struct mmu_gather, mmu_gathers);

If I understand this correct then this should read:

/*
* Users of the generic TLB shootdown
* must define mmu_gathers like this:
* DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
*/

The main difference is "declare" => "define".

If you already updated this in you serie then please ignore this mail.

Sam


\
 
 \ /
  Last update: 2011-01-26 20:21    [W:0.186 / U:3.056 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site