lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH -mmotm] backlight: apple_bl depends on ACPI
    From: Randy Dunlap <randy.dunlap@oracle.com>

    apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.

    drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
    drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
    drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
    drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
    drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
    drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
    drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
    drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
    drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
    drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
    drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
    drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
    drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
    drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
    drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
    drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
    drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'

    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Cc: Matthew Garrett <mjg@redhat.com>
    Cc: Richard Purdie <rpurdie@rpsys.net>
    ---
    drivers/video/backlight/Kconfig | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- mmotm-2011-0125-1547.orig/drivers/video/backlight/Kconfig
    +++ mmotm-2011-0125-1547/drivers/video/backlight/Kconfig
    @@ -238,10 +238,10 @@ config BACKLIGHT_MAX8925

    config BACKLIGHT_APPLE
    tristate "Apple Backlight Driver"
    - depends on X86
    + depends on X86 && ACPI
    help
    If you have an Intel-based Apple say Y to enable a driver for its
    - backlight
    + backlight.

    config BACKLIGHT_TOSA
    tristate "Sharp SL-6000 Backlight Driver"

    \
     
     \ /
      Last update: 2011-01-26 20:21    [W:0.029 / U:2.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site