lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] x86, amd: Support L3 Cache Partitioning on AMD family 0x15 CPUs
On Wed, Jan 26, 2011 at 05:56:37AM -0500, Ingo Molnar wrote:
>
> * Hans Rosenfeld <hans.rosenfeld@amd.com> wrote:
>
> > L3 Cache Partitioning allows selecting which of the 4 L3 subcaches can
> > be used for evictions by the L2 cache of each compute unit. By writing a
> > 4-bit hexadecimal mask into the the sysfs file /sys/devices/system/cpu/\
> > cpuX/cache/index3/subcaches, the user can set the enabled subcaches for
> > a CPU. The settings are directly read from and written to the hardware,
> > so there is no way to have contradicting settings for two CPUs belonging
> > to the same compute unit. Writing will always overwrite any previous
> > setting for a compute unit.
> >
> > Signed-off-by: Hans Rosenfeld <hans.rosenfeld@amd.com>
> > ---
> > arch/x86/include/asm/amd_nb.h | 3 +
> > arch/x86/kernel/amd_nb.c | 55 +++++++++++++++++++++++++
> > arch/x86/kernel/cpu/intel_cacheinfo.c | 73 +++++++++++++++++++++++++++-----
> > 3 files changed, 119 insertions(+), 12 deletions(-)
>
> I have picked up the other 3 patches, but this one causes this build failure:
>
> arch/x86/kernel/amd_nb.c: In function ?amd_get_subcaches?:
> arch/x86/kernel/amd_nb.c:129:36: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
> arch/x86/kernel/amd_nb.c: In function ?amd_set_subcaches?:
> arch/x86/kernel/amd_nb.c:154:28: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
> arch/x86/kernel/amd_nb.c:155:36: error: ?struct cpuinfo_x86? has no member named ?compute_unit_id?
> arch/x86/kernel/amd_nb.c: In function ?amd_get_subcaches?:
> arch/x86/kernel/amd_nb.c:130:1: warning: control reaches end of non-void function

Hrmpf. CONFIG_SMP.

Sorry for the noise, fixed patch will follow shortly.


Hans


--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown



\
 
 \ /
  Last update: 2011-01-26 18:07    [W:0.062 / U:5.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site