lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 26 Jan 2011 17:30:45 +0300
FromDan Carpenter <>
SubjectRe: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function.
Also when it does:
memcpy(ft1000dev->tx_buf, *pUcFile, byte_length);

That should probably be:
memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4);

Otherwise we're probably copying garbage from beyond the end of *pUcFile
to the ->tx_buf. ft1000dev->tx_buf is hopefully initialized to zero at
this point?

regards,
dan carpenter



\
 
 \ /
  Last update: 2011-01-26 15:33    [from the cache]
©2003-2010