Messages in this thread |  | | | Date | Wed, 26 Jan 2011 14:56:42 +0100 | | Subject | Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function. | | From | Belisko Marek <> |
| |
On Wed, Jan 26, 2011 at 2:43 PM, Dan Carpenter <error27@gmail.com> wrote: > On Wed, Jan 26, 2011 at 04:07:18PM +0300, Dan Carpenter wrote: >> You didn't introduce it but do you know what the code is trying to do >> here? >> >> byte_length = word_length * 4; >> >> if (byte_length % 4) > > Actually this check is pointless. word_length * 4 is always > aligned at 4 bytes. OK will post in separate patch. Original was just about coding style. Thanks for reviewing. > > regards, > dan carpenter > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
thanks,
marek
-- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |