Messages in this thread Patch in this message | | | From | "Berg, Johannes" <> | Date | Wed, 26 Jan 2011 10:23:39 +0000 | Subject | RE: [PATCH] firmware_classs: change val uevent's type to bool |
| |
________________________________________ From: Bob Liu [lliubbo@gmail.com] Sent: Wednesday, January 26, 2011 11:03 To: Berg, Johannes Cc: linux-kernel@vger.kernel.org; chrisw@sous-sol.org; Winkler, Tomas; dmitry.torokhov@gmail.com; gregkh@suse.de Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool
On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@intel.com> wrote: > @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, > f_dev->parent = device; > f_dev->class = &firmware_class; > > - dev_set_uevent_suppress(f_dev, true); > + if (uevent) > + dev_set_uevent_suppress(f_dev, true); > > Everything but this is a no-op basically, but you didn't even describe this change? >
Hmm.. Sorry for that, but I mentioned that by "fix a place missing uevent check". I added this check because I think it should be paired with following dev_set_uevent_suppress(f_dev, false).
I don't think it should -- if you don't want uevents, then they should _always_ be suppressed, right?
johannes -------------------------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
| |