lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRE: [PATCH] firmware_classs: change val uevent's type to bool

________________________________________
From: Bob Liu [lliubbo@gmail.com]
Sent: Wednesday, January 26, 2011 11:03
To: Berg, Johannes
Cc: linux-kernel@vger.kernel.org; chrisw@sous-sol.org; Winkler, Tomas; dmitry.torokhov@gmail.com; gregkh@suse.de
Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool

On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@intel.com> wrote:
> @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
> f_dev->parent = device;
> f_dev->class = &firmware_class;
>
> - dev_set_uevent_suppress(f_dev, true);
> + if (uevent)
> + dev_set_uevent_suppress(f_dev, true);
>
> Everything but this is a no-op basically, but you didn't even describe this change?
>


Hmm.. Sorry for that, but I mentioned that by "fix a place missing
uevent check".
I added this check because I think it should be paired with following
dev_set_uevent_suppress(f_dev, false).

I don't think it should -- if you don't want uevents, then they should _always_ be suppressed, right?

johannes
--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


\
 
 \ /
  Last update: 2011-01-26 11:27    [W:0.032 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site