Messages in this thread | | | Date | Tue, 25 Jan 2011 16:44:03 +0800 | Subject | Re: [PATCH] net: NETCONSOLE_DYNAMIC need CONFIGFS_FS=y | From | Yong Zhang <> |
| |
On Tue, Jan 25, 2011 at 4:42 PM, Yong Zhang <yong.zhang0@gmail.com> wrote: > On Tue, Jan 25, 2011 at 4:39 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote: >> On Tue, Jan 25, 2011 at 04:22:28PM +0800, Yong Zhang wrote: >>>With CONFIGFS_FS=m && NETCONSOLE_DYNAMIC=y, build error: >>> >>>drivers/built-in.o: In function `netconsole_target_put': >>>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `netconsole_target_get': >>>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>>build/drivers/net/netconsole.c:127: undefined reference to `config_item_get' >>>drivers/built-in.o: In function `netconsole_target_put': >>>build/drivers/net/netconsole.c:133: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `drop_netconsole_target': >>>build/drivers/net/netconsole.c:634: undefined reference to `config_item_put' >>>drivers/built-in.o: In function `make_netconsole_target': >>>build/drivers/net/netconsole.c:607: undefined reference to `config_item_init_type_name' >>>drivers/built-in.o: In function `dynamic_netconsole_init': >>>build/drivers/net/netconsole.c:109: undefined reference to `config_group_init' >>>build/drivers/net/netconsole.c:111: undefined reference to `configfs_register_subsystem' >>>drivers/built-in.o: In function `dynamic_netconsole_exit': >>>build/drivers/net/netconsole.c:116: undefined reference to `configfs_unregister_subsystem' >>> >> >> Yeah, this was reported, another way to fix this is "select CONFIGFS_FS". >> Using "select" makes you configure NETCONSOLE_DYNAMIC without caring >> about if you have configured CONFIGFS_FS=y, which seems better. > > You mean commit d9f9ab51e55e36379773752ffeaac677b080d469?
That commit show "select CONFIGFS_FS" is the wrong way :(
> > Thanks, > Yong > > -- > Only stand for myself >
-- Only stand for myself -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |