lkml.org 
[lkml]   [2011]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer
On 01/25/2011 03:38 PM, Peter Huewe wrote:
>
> This patch fixes the warning "Using plain integer as NULL pointer",
> generated by sparse, by replacing the offending 0s with NULL.
>
> KernelVersion: linus' tree-c723fdab
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/media/video/cx231xx/cx231xx-417.c | 4 ++--
> drivers/media/video/cx231xx/cx231xx-cards.c | 16 ++++++++--------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/video/cx231xx/cx231xx-417.c
> b/drivers/media/video/cx231xx/cx231xx-417.c
> index fc9526a..f8f0e59 100644
> --- a/drivers/media/video/cx231xx/cx231xx-417.c
> +++ b/drivers/media/video/cx231xx/cx231xx-417.c
> @@ -942,13 +942,13 @@ static int cx231xx_load_firmware(struct cx231xx
> *dev)
>
> p_current_fw = vmalloc(1884180 * 4);
> p_fw = p_current_fw;
> - if (p_current_fw == 0) {
> + if (p_current_fw == NULL) {
> dprintk(2, "FAIL!!!\n");
> return -1;
> }
>
> p_buffer = vmalloc(4096);
> - if (p_buffer == 0) {
> + if (p_buffer == NULL) {
> dprintk(2, "FAIL!!!\n");
> return -1;
> }
> diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c
> b/drivers/media/video/cx231xx/cx231xx-cards.c
> index 588f3e8..5b9b5f4 100644
> --- a/drivers/media/video/cx231xx/cx231xx-cards.c
> +++ b/drivers/media/video/cx231xx/cx231xx-cards.c
> @@ -357,19 +357,19 @@ struct cx231xx_board cx231xx_boards[] = {
> .type = CX231XX_VMUX_TELEVISION,
> .vmux = CX231XX_VIN_3_1,
> .amux = CX231XX_AMUX_VIDEO,
> - .gpio = 0,
> + .gpio = NULL,
> }, {
> .type = CX231XX_VMUX_COMPOSITE1,
> .vmux = CX231XX_VIN_2_1,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> }, {
> .type = CX231XX_VMUX_SVIDEO,
> .vmux = CX231XX_VIN_1_1 |
> (CX231XX_VIN_1_2 << 8) |
> CX25840_SVIDEO_ON,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> } },
> },
> [CX231XX_BOARD_HAUPPAUGE_USBLIVE2] = {
> @@ -386,14 +386,14 @@ struct cx231xx_board cx231xx_boards[] = {
> .type = CX231XX_VMUX_COMPOSITE1,
> .vmux = CX231XX_VIN_2_1,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> }, {
> .type = CX231XX_VMUX_SVIDEO,
> .vmux = CX231XX_VIN_1_1 |
> (CX231XX_VIN_1_2 << 8) |
> CX25840_SVIDEO_ON,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> } },
> },
> [CX231XX_BOARD_PV_PLAYTV_USB_HYBRID] = {
> @@ -420,19 +420,19 @@ struct cx231xx_board cx231xx_boards[] = {
> .type = CX231XX_VMUX_TELEVISION,
> .vmux = CX231XX_VIN_3_1,
> .amux = CX231XX_AMUX_VIDEO,
> - .gpio = 0,
> + .gpio = NULL,
> }, {
> .type = CX231XX_VMUX_COMPOSITE1,
> .vmux = CX231XX_VIN_2_1,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> }, {
> .type = CX231XX_VMUX_SVIDEO,
> .vmux = CX231XX_VIN_1_1 |
> (CX231XX_VIN_1_2 << 8) |
> CX25840_SVIDEO_ON,
> .amux = CX231XX_AMUX_LINE_IN,
> - .gpio = 0,
> + .gpio = NULL,
> } },
> },
> };
> --
> 1.7.2.2
>
Reviewed-by: Devin Heitmueller <dheitmueller@hauppauge.com>

--
Devin Heitmueller
Senior Software Engineer
Hauppauge Computer Works



\
 
 \ /
  Last update: 2011-01-25 22:41    [W:0.934 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site