lkml.org 
[lkml]   [2011]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] USB: EHCI: Rearrange EHCI_URB_TRACE code to avoid GCC-4.6 warnings.
    Date
    With pre-release GCC-4.6, we get a 'set but not used' warning when
    EHCI_URB_TRACE is not set because we set the qtd variable without
    using it.

    Rearrange the statements so that we only set qtd if it will be used.

    Signed-off-by: David Daney <ddaney@caviumnetworks.com>
    ---
    drivers/usb/host/ehci-q.c | 18 ++++++++++--------
    1 files changed, 10 insertions(+), 8 deletions(-)

    diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
    index 233c288..fe99895 100644
    --- a/drivers/usb/host/ehci-q.c
    +++ b/drivers/usb/host/ehci-q.c
    @@ -1107,22 +1107,24 @@ submit_async (
    struct list_head *qtd_list,
    gfp_t mem_flags
    ) {
    - struct ehci_qtd *qtd;
    int epnum;
    unsigned long flags;
    struct ehci_qh *qh = NULL;
    int rc;

    - qtd = list_entry (qtd_list->next, struct ehci_qtd, qtd_list);
    epnum = urb->ep->desc.bEndpointAddress;

    #ifdef EHCI_URB_TRACE
    - ehci_dbg (ehci,
    - "%s %s urb %p ep%d%s len %d, qtd %p [qh %p]\n",
    - __func__, urb->dev->devpath, urb,
    - epnum & 0x0f, (epnum & USB_DIR_IN) ? "in" : "out",
    - urb->transfer_buffer_length,
    - qtd, urb->ep->hcpriv);
    + {
    + struct ehci_qtd *qtd;
    + qtd = list_entry(qtd_list->next, struct ehci_qtd, qtd_list);
    + ehci_dbg(ehci,
    + "%s %s urb %p ep%d%s len %d, qtd %p [qh %p]\n",
    + __func__, urb->dev->devpath, urb,
    + epnum & 0x0f, (epnum & USB_DIR_IN) ? "in" : "out",
    + urb->transfer_buffer_length,
    + qtd, urb->ep->hcpriv);
    + }
    #endif

    spin_lock_irqsave (&ehci->lock, flags);
    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-01-25 19:03    [W:0.023 / U:214.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site