lkml.org 
[lkml]   [2011]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC] [PATCH 2.6.37-rc5-tip 4/20] 4: uprobes: Adding and remove a uprobe in a rb tree.
    From
    Date
    On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
    > +/* Should be called lock-less */
    > +static void put_uprobe(struct uprobe *uprobe)
    > +{
    > + if (atomic_dec_and_test(&uprobe->ref))
    > + kfree(uprobe);
    > +}

    Since this instantly frees the uprobe once ref hits 0, the
    atomic_inc_not_zero() in find_uprobe() doesn't really make sense does
    it?


    \
     
     \ /
      Last update: 2011-01-25 13:19    [W:0.023 / U:1.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site