Messages in this thread | | | Date | Tue, 25 Jan 2011 10:29:05 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH v4 01/19] ARM: Make the argument to virt_to_phys() "const volatile" |
| |
On Tue, Jan 25, 2011 at 11:00:10AM +0100, Arnd Bergmann wrote: > On Monday 24 January 2011, Stephen Boyd wrote: > > On 01/24/2011 09:55 AM, Catalin Marinas wrote: > > > Changing the virt_to_phys() argument to "const volatile void *" avoids > > > compiler warnings in some situations where this function is used. > > > > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> > > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > Acked-by: Stephen Boyd <sboyd@codeaurora.org> > > > > Any chance we can get this one patch into 2.6.38? It fixes a warning for > > MSM. > > Stephen, you might want to have a look at why the warning even appears > on MSM. Most uses of 'volatile' are misguided, and there could be an > actual bug in there.
It's actually the right thing - look at x86's definition:
static inline phys_addr_t virt_to_phys(volatile void *address)
| |