lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] staging/ste_rmi4: Remove obsolete cleanup for clientdata
    Date
    A few new i2c-drivers came into the kernel which clear the clientdata-pointer
    on exit or error. This is obsolete meanwhile, the core will do it.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
    Cc: Linus Walleij <linus.walleij@stericsson.com>
    ---

    Compile tested only.

    drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
    index e8f047e..c9207de 100644
    --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
    +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
    @@ -989,7 +989,7 @@ static int __devinit synaptics_rmi4_probe
    retval = input_register_device(rmi4_data->input_dev);
    if (retval) {
    dev_err(&client->dev, "%s:input register failed\n", __func__);
    - goto err_input_register;
    + goto err_query_dev;
    }

    /* Clear interrupts */
    @@ -1011,8 +1011,6 @@ static int __devinit synaptics_rmi4_probe
    err_request_irq:
    free_irq(platformdata->irq_number, rmi4_data);
    input_unregister_device(rmi4_data->input_dev);
    -err_input_register:
    - i2c_set_clientdata(client, NULL);
    err_query_dev:
    if (platformdata->regulator_en) {
    regulator_disable(rmi4_data->regulator);
    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-01-24 11:49    [W:0.021 / U:59.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site