Messages in this thread | | | From | Po-Yu Chuang <> | Date | Tue, 25 Jan 2011 10:46:18 +0800 | Subject | Re: [PATCH v5] net: add Faraday FTMAC100 10/100 Ethernet driver |
| |
Dear Eric,
On Mon, Jan 24, 2011 at 11:07 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le lundi 24 janvier 2011 à 20:39 +0800, Po-Yu Chuang a écrit : >> From: Po-Yu Chuang <ratbert@faraday-tech.com> >> + >> + priv->tx_pending++; >> + if (priv->tx_pending == TX_QUEUE_ENTRIES) { >> + if (net_ratelimit()) >> + netdev_info(netdev, "tx queue full\n"); > > Hmm, I guess you didnt tested your driver with a pktgen flood ;) > > This 'netdev_info(netdev, "tx queue full\n");' is not necessary, since > its a pretty normal condition for a driver (to fill its TX ring buffer)
Errr... No, I didn't test it with pktgen. I tested it with normal NFS usages. I'll try it.
best regards, Po-Yu Chuang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |