lkml.org 
[lkml]   [2011]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 14/16] KVM-GST: KVM Steal time registration
From
Date
On Mon, 2011-01-24 at 18:31 -0500, Rik van Riel wrote:
> On 01/24/2011 01:06 PM, Glauber Costa wrote:
> > Register steal time within KVM. Everytime we sample the steal time
> > information, we update a local variable that tells what was the
> > last time read. We then account the difference.
> >
> > Signed-off-by: Glauber Costa<glommer@redhat.com>
> > CC: Rik van Riel<riel@redhat.com>
> > CC: Jeremy Fitzhardinge<jeremy.fitzhardinge@citrix.com>
> > CC: Peter Zijlstra<peterz@infradead.org>
> > CC: Avi Kivity<avi@redhat.com>
>
> On second thought - how does this deal with cpu hotplug and
> hot unplug?
>
> Do you allocate a new one of these structs every time a cpu
> is hot unplugged and then hotplugged, leaking the old one?
>
> Will leaving the old value around confuse the steal time
> calculation?

If you look closely, there are no allocations happening at all,
it's all static.



\
 
 \ /
  Last update: 2011-01-25 02:27    [W:1.549 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site